declarations placement issue

[Ala'a Mohammad]

Content preview: Hi, Please, correct me If I'm wrong. in the expansion of the
following (using cl-who from quicklisp) [...]

Content analysis details: (-0.7 points, 5.0 required)

pts rule name description
---- ---------------------- --------------------------------------------------
-0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low
trust
[209.85.212.51 listed in list.dnswl.org]
0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider
(amalawi[at]gmail.com)
-0.0 SPF_PASS SPF: sender matches SPF record
0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid
Archived-At: <http://permalink.gmane.org/gmane.lisp.who.general/303>

Hi,

Please, correct me If I'm wrong.

in the expansion of the following (using cl-who from quicklisp)

(with-html-output (var)
(declare (special var)))
;=>
(LET ((VAR VAR))
(PROGN
(DECLARE (SPECIAL VAR))))

I think that the declaration is placed in the wrong place. CLHS does
not specify any declarations for PROGN entry. and in this declaration
provides information about the bindings of LET, thus I thought the
correct expansion should be:

(with-html-output (var)
(declare (special var)))
;=>
(LET ((VAR VAR))
(DECLARE (SPECIAL VAR))
(PROGN))

the fix should should only affect with-html-output (since
with-html-output-to-string passes the declarations to the former
macro)

Regards,

Ala'a

[Edi Weitz]

Content preview: Sorry for the late reply... :( Yeah, look like you're right.
I think the documentation is to blame in that it talks about declarations
although I think CL-WHO never took care of them. I'd suggest to just remove
this from the docs unless you have a patch. (I myself am too busy with other
things to work on the code.) [...]

Content analysis details: (-100.7 points, 5.0 required)

pts rule name description
---- ---------------------- --------------------------------------------------
-0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low
trust
[209.85.160.51 listed in list.dnswl.org]
-100 USER_IN_WHITELIST From: address is in the user's white-list
0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider
(nhabedi[at]gmail.com)
-0.0 SPF_PASS SPF: sender matches SPF record
0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid
Archived-At: <http://permalink.gmane.org/gmane.lisp.who.general/304>

Sorry for the late reply... :(

Yeah, look like you're right. I think the documentation is to blame
in that it talks about declarations although I think CL-WHO never took
care of them. I'd suggest to just remove this from the docs unless
you have a patch. (I myself am too busy with other things to work on
the code.)

Thanks,
Edi.

Post by Ala'a Mohammad
Hi,
Please, correct me If I'm wrong.
in the expansion of the following (using cl-who from quicklisp)
(with-html-output (var)
 (declare (special var)))
;=>
(LET ((VAR VAR))
  (PROGN
     (DECLARE (SPECIAL VAR))))
I think that the declaration is placed in the wrong place. CLHS does
not specify any declarations for PROGN entry. and in this declaration
provides information about the bindings of LET, thus I thought the
(with-html-output (var)
 (declare (special var)))
;=>
(LET ((VAR VAR))
  (DECLARE (SPECIAL VAR))
  (PROGN))
the fix should should only affect with-html-output (since
with-html-output-to-string passes the declarations to the former
macro)
Regards,
Ala'a
_______________________________________________
cl-who-devel site list
http://common-lisp.net/mailman/listinfo/cl-who-devel

[Ala'a Mohammad]

Content preview: Thanks for taking the time to reply. I've already forked the
github version and got the patch approved by Hans. Best wishes, [...]

Content analysis details: (-0.7 points, 5.0 required)

pts rule name description
---- ---------------------- --------------------------------------------------
-0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low
trust
[209.85.220.179 listed in list.dnswl.org]
0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider
(amalawi[at]gmail.com)
-0.0 SPF_PASS SPF: sender matches SPF record
0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid
Archived-At: <http://permalink.gmane.org/gmane.lisp.who.general/305>

Thanks for taking the time to reply.

I've already forked the github version and got the patch approved by Hans.

Best wishes,

Ala'a.

Post by Edi Weitz
Sorry for the late reply... :(
Yeah, look like you're right.  I think the documentation is to blame
in that it talks about declarations although I think CL-WHO never took
care of them.  I'd suggest to just remove this from the docs unless
you have a patch.  (I myself am too busy with other things to work on
the code.)
Thanks,
Edi.

Post by Ala'a Mohammad
Hi,
Please, correct me If I'm wrong.
in the expansion of the following (using cl-who from quicklisp)
(with-html-output (var)
 (declare (special var)))
;=>
(LET ((VAR VAR))
  (PROGN
     (DECLARE (SPECIAL VAR))))
I think that the declaration is placed in the wrong place. CLHS does
not specify any declarations for PROGN entry. and in this declaration
provides information about the bindings of LET, thus I thought the
(with-html-output (var)
 (declare (special var)))
;=>
(LET ((VAR VAR))
  (DECLARE (SPECIAL VAR))
  (PROGN))
the fix should should only affect with-html-output (since
with-html-output-to-string passes the declarations to the former
macro)
Regards,
Ala'a
_______________________________________________
cl-who-devel site list
http://common-lisp.net/mailman/listinfo/cl-who-devel

_______________________________________________
cl-who-devel site list
http://common-lisp.net/mailman/listinfo/cl-who-devel